bugfix/notion fix pagination in BlocksChildrenEndpoint and DatabasesEndpoint #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardchor
force-pushed
the
fix-notion-connector-iteration
branch
2 times, most recently
from
d233ddb to
446b321
Compare
potter-potter
requested review from
rbiseck3,
potter-potter,
vangheem and
ahmetmeleq
and removed request for
vangheem,
ahmetmeleq and
rbiseck3
|
I had asked this get folded into an existing PR that's migrating the notion connector to v2: #162 |
|
@hardchor Thanks so much! We are just about to merge in a new Notion connector (we're moving all connectors to V2) and will make sure this is in there. |
hardchor
force-pushed
the
fix-notion-connector-iteration
branch
from
446b321 to
bb757f9
Compare
hardchor
force-pushed
the
fix-notion-connector-iteration
branch
from
e61f279 to
f7a3d86
Compare
This reverts commit f7a3d86.
|
issue has been fixed in PR #162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why the notion runner was running in circles when ingesting bigger pages (with more than 100 blocks) - turns out the recursive child block getters forgot to point at the next page / cursor