-
Notifications
You must be signed in to change notification settings - Fork 17
NEXUS-909 feat Enable custom server URLs in the workflow endpoints #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9639062.
This reverts commit bd8d0a9.
> [!IMPORTANT] > revert base_url changes ``` git checkout yuming/custom_url src/unstructured_client/destinations.py git checkout yuming/custom_url src/unstructured_client/sources.py git checkout yuming/custom_url src/unstructured_client/jobs.py git checkout yuming/custom_url src/unstructured_client/workflows.py git checkout yuming/custom_url src/unstructured_client/general.py ``` > Linting report available at: <https://app.speakeasy.com/org/unstructured/unstructured5xr/linting-report/58686777b39d3936df6f61710ab738d8> > OpenAPI Change report available at: <https://app.speakeasy.com/org/unstructured/unstructured5xr/changes-report/d1b6cec20149892cd22bac1b6ad7c703> # SDK update Based on: - OpenAPI Doc - Speakeasy CLI 1.537.0 (2.588.0) https://github.com/speakeasy-api/speakeasy ## Versioning Version Bump Type: [minor] - 🤖 (automated) ## OpenAPI Change Summary No specification changes ## PYTHON CHANGELOG ## core: 5.15.0 - 2025-04-17 ### 🐝 New Features - Remove python-dateutil dependency *(commit by [@bflad](https://github.com/bflad))* --------- Co-authored-by: speakeasybot <[email protected]> Co-authored-by: Yuming Long <[email protected]>
This reverts commit 8d46634.
PastelStorm
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
server_url
logic in workflow endpoints is now the same as partition endpoint: user should be able to pass it from Client init to each endpoint and if no input we will just fallback to default based on endpoint operationbase_url
in each endpoint (see chore: 🐝 Update SDK - Generate 0.34.0 #266).genignore
so that speakeasy bot ignore the ^^ changes -> but i don't like this way since we might still need to modify workflow API endpoint and speakeasy bot will ignore them if we do_get_url
inbasesdk.py
but thats in deeper stack of code might be difficult to read the flow (and write tests)Test
you got three ways of using the url
and responses would be (last one is default fallback)