Luke/CVE bump #3928
Merged
Luke/CVE bump #3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
six5532one
reviewed
Feb 18, 2025
requirements/deps/constraints.txt
Outdated
| @@ -18,3 +18,5 @@ botocore<1.34.132 | |||
| importlib-metadata>=8.5.0 | |||
| # (austin): Versions below this have a different interface for passing parameters | |||
| unstructured-client>=0.23.0,<0.26.0 | |||
| # (luke): conflicting versions installed. pinned to 5.3.0 for now. | |||
| lxml==5.3.0 | |||
There was a problem hiding this comment.
Looks like @ahmetmeleq also opened a PR to address CVEs but it doesn't include this pin. Would the changes in #3925 resolve the CVE?
There was a problem hiding this comment.
looks like that PR would resolve the cryptography CVE and label-studio sdk but would fix the transformers CVE in version 4.442 thats resolved in version 4.48.0
There was a problem hiding this comment.
tested removing the constraint and it doesnt seem like anything required 5.3.0 so that might have just been an error on my part
|
If the image seems like it's working, the changes seem good to me |
tabossert
approved these changes
Feb 19, 2025
six5532one
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumping dependancies and updated the tokenizer constraint