Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/pydantic #93

Merged
merged 13 commits into from
Oct 18, 2023
Merged

Dev/pydantic #93

merged 13 commits into from
Oct 18, 2023

Conversation

beardyFace
Copy link
Member

No description provided.

README.md Outdated
```
python3 example_training_loops.py openai --task HalfCheetah-v4 TD3
python example_training_loops.py run --gym openai --task HalfCheetah-v4 TD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 3, TD3

target_param.data.copy_(param.data * self.tau + target_param.data * (1.0 - self.tau))

for target_param, param in zip(self.target_critic_net.Q2.parameters(), self.critic_net.Q2.parameters()):
for target_param, param in zip(self.target_critic_net.parameters(), self.critic_net.parameters()):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two targets nets. should be differents

@dvalenciar dvalenciar merged commit 41abafe into main Oct 18, 2023
1 check passed
@beardyFace beardyFace deleted the dev/pydantic branch October 18, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants