Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRONTEND] Set up modular routes component #154

Closed
6 tasks
choden-dev opened this issue Mar 16, 2024 · 0 comments · Fixed by #208
Closed
6 tasks

[FRONTEND] Set up modular routes component #154

choden-dev opened this issue Mar 16, 2024 · 0 comments · Fixed by #208
Assignees
Labels
frontend relating to code in the /client directory good first issue Good for newcomers

Comments

@choden-dev
Copy link
Member

Is your feature request related to a problem? Please describe.
We should not have to always edit the App.tsx file every time we add a new route. Therefore we should create a separate module that we can have all of our routes in.

Describe the solution you'd like
This would be a good way to learn about react and ES6 javascript syntax

BEFORE MERGING

  • Storybooks created where possible
  • Tested with nock if data fetching
  • Tests written for critical interactions
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added frontend relating to code in the /client directory good first issue Good for newcomers labels Mar 16, 2024
@choden-dev choden-dev added this to the Club sign-up functionality milestone Mar 17, 2024
@ganznz ganznz self-assigned this Apr 2, 2024
@choden-dev choden-dev linked a pull request Apr 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend relating to code in the /client directory good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants