Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

154 modularise routes #208

Merged
merged 2 commits into from
Apr 2, 2024
Merged

154 modularise routes #208

merged 2 commits into from
Apr 2, 2024

Conversation

ganznz
Copy link
Contributor

@ganznz ganznz commented Apr 2, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 5f8b635):

https://uasc-ceebc--pr208-154-modularise-route-p9nxio9s.web.app

(expires Tue, 09 Apr 2024 23:28:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

choden-dev
choden-dev requested changes Apr 2, 2024
View reviewed changes
server/src/business-layer/services/AuthService.test.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove this file from the pr with git checkout master server/src/business-layer/services/AuthService.test.ts

server/src/business-layer/services/AuthService.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed git checkout master server/src/business-layer/services/AuthService.ts

server/src/business-layer/utils/AuthServiceClaims.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed git checkout master server/src/business-layer/utils/AuthServiceClaims.ts

@choden-dev choden-dev linked an issue Apr 2, 2024 that may be closed by this pull request
[FRONTEND] Set up modular routes component #154
Closed
6 tasks
@ganznz ganznz merged commit 0cf0441 into master Apr 2, 2024
6 checks passed
@ganznz ganznz deleted the 154-modularise-routes branch April 2, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choden-dev choden-dev choden-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FRONTEND] Set up modular routes component
2 participants
@ganznz @choden-dev