Refactor double-fetch for token changes #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would perform a `getIdTokenResult()`, followed by a `getIdToken()` call. This is two API calls to Firebase, and can be simplfied by using the `token` property from the resutl of `getIdTokenResult()`. Also updates the `onIdTokenChanged` flow to handle errors more gracefully, by `return`ing early if we are unable to retrieve the token details (rather than setting `null` data to memory. Observing the source of `getIdTokenResult` at https://github.com/firebase/firebase-js-sdk/blob/6d31930b3abe1588ae81a5c14b59cd386fddc718/packages/auth/src/core/user/id_token_result.ts#L55-L88 it is evident that it calls `getIdToken` internally.
|
Visit the preview URL for this PR (updated for commit 1db3ebd): https://uasc-ceebc--pr212-refactor-auth-token-k6dkefud.web.app (expires Wed, 10 Apr 2024 05:30:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa |
choden-dev
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would perform a
getIdTokenResult(), followed by agetIdToken()call. This is two API calls to Firebase, and can be simplfied by using thetokenproperty from the resutl ofgetIdTokenResult().Also updates the
onIdTokenChangedflow to handle errors more gracefully, byreturning early if we are unable to retrieve the token details (rather than settingnulldata to memory.Observing the source of
getIdTokenResultathttps://github.com/firebase/firebase-js-sdk/blob/6d31930b3abe1588ae81a5c14b59cd386fddc718/packages/auth/src/core/user/id_token_result.ts#L55-L88 it is evident that it calls
getIdTokeninternally.See https://github.com/firebase/firebase-js-sdk/blob/6d31930b3abe1588ae81a5c14b59cd386fddc718/packages/auth/src/core/user/user_impl.ts#L102-L116 for the original
getIdTokensource.