remove hard redirect on admin pages to improve UX #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Visit the preview URL for this PR (updated for commit 5ee9b91): https://uasc-ceebc--pr710-709-frontend-fix-ux-qvxhz6yl.web.app (expires Sun, 04 Aug 2024 20:49:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa |
choden-dev
force-pushed
the
709-frontend-fix-ux-issues-caused-by-non-persisting-auth-state-with-ssg
branch
from
1993903 to
5ee9b91
Compare
choden-dev
deleted the
709-frontend-fix-ux-issues-caused-by-non-persisting-auth-state-with-ssg
branch
choden-dev
added a commit
that referenced
this pull request
Jul 28, 2024
* Update README.md (#666) * 287 Remove payment intent check in membership payment (#672) Removed `hasProcessingPaymentIntent` from StripeService.ts Removed corresponding check in the endpoint. * 650 exec img comp (#664) * Added ExecImage component with hover and touch functionality. - Created ExecImage component to display executive images with hover and touch effects. - Integrated Next.js Image component for optimized image loading. - Added props for executive title and name, displayed on hover and touch. - Implemented CSS for hover effect and text overlay. - Created Storybook stories for visual testing and documentation. - Added ExecImageList component to render multiple ExecImage components using an array. * prettier and codegen * Refactored ExecImage component and its CSS to avoid using JavaScript for hover effects, using Tailwind CSS. * adjusted colour css * adjusted colour css * 651 Document all backend endpoints (#673) * Add jsdoc to UserController * Tsoa generation and jsdoc for StripeWebhook endpoint * Add jsdoc for SignupController * Jsdoc for PaymentController and add fullstops * Add jsdoc for BookingController * 651 Add jsdoc for AdminController (#674) * 651 Add jsdoc for AdminController * enforce dietary requirements on booking creation (#676) * 671-readme-for-server (#675) I hope I didn't misunderstand this ticket... Created a README.md file with the Backend-Architecture part of the wiki. * 669 Delete docs folder (#679) Removed * 670 Create readme including frontend wiki page (#678) There was already a README.md file so instead, I just added another heading with a link redirecting to the wiki. * 566 Delete preview channel upon merge (#680) * 566 Delete preview channel upon merge Have added the feature to the pre-existing workflow action as per [this pull request on action-hosting-deploy](FirebaseExtended/action-hosting-deploy#65) * Add new workflow and revert changes Added a new delete firebase channel upon PR close action. Reverted the not implemented changes from the firebase deployment on PR. * 566 delete preview channel on merge (#682) * 566 Delete preview channel upon merge Have added the feature to the pre-existing workflow action as per [this pull request on action-hosting-deploy](FirebaseExtended/action-hosting-deploy#65) * Add new workflow and revert changes Added a new delete firebase channel upon PR close action. Reverted the not implemented changes from the firebase deployment on PR. * Changed the preview channel to delete Instead of just using the `github.head_ref` as the preview channel id, will need to make some changes as the preview channel created uses a different preview id. * Substring shell workaround for PR title * 566 delete preview channel on merge (#683) * 566 Delete preview channel upon merge Have added the feature to the pre-existing workflow action as per [this pull request on action-hosting-deploy](FirebaseExtended/action-hosting-deploy#65) * Add new workflow and revert changes Added a new delete firebase channel upon PR close action. Reverted the not implemented changes from the firebase deployment on PR. * Changed the preview channel to delete Instead of just using the `github.head_ref` as the preview channel id, will need to make some changes as the preview channel created uses a different preview id. * Substring shell workaround for PR title * Remove extra " at the end * use the wrapped of the booking creation popup (#686) * update the email template and add pug for templating (#689) * copy templates to build outputs (#691) * copy templates to build outputs * make email template only compile once * revert unneeded change * Create interface in firebase.ts (#692) * Create interface in firebase.ts * Add other important data fields to the EventSlot interface Added start/end dates, location, image url. Fixed a typo * Update comments * add docs (#690) * Google map widget on contact page (#693) * implementation * fixed address * 694 frontend fix overflox issue on contact page (#696) * div used * fixed overflow * max w fixed * fix table on admin availability view (#698) * Update README.md (#700) * change transforms on svgs (#701) * removed unneeded line (#547) * removed unneeded line * removed next button * allow clicking table row to invoke callback (#705) * allow clicking table row to invoke callback * add example * fix booking creation if user already has a booking (#707) * fix booking creation * fix test * add indicators for statuses on admin booking creation (#712) * add indicators for statuses * fix search query * add trim * 610 frontend sort the membership prices before returning thme (#708) * Added Sorting for the membership prices * Updated sorting method and added test for sorting method * Fixed nit * remove hard redirect on admin pages (#710) --------- Co-authored-by: eddieyw <[email protected]> Co-authored-by: Jeffery <[email protected]> Co-authored-by: AzizP786 <[email protected]> Co-authored-by: zlrkw11 <[email protected]> Co-authored-by: Albert Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the redirects does not play nicely with SSG, as the auth state seems to reset when the page is lazy-loaded.
We assume the only people accessing this route are admins, and if its is not, then an infinite loader is an acceptable experience.