Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the booking confirmation to be explicit about check in/out #734

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

choden-dev
Copy link
Member

@choden-dev choden-dev commented Aug 1, 2024

Can it show the day after, the same as how booking conf on website page shows the date after

Added relevant helper functions and changed formatting everywhere

image

also changed check in to 11:00am

@choden-dev choden-dev added the improvement New feature or request label Aug 1, 2024
@choden-dev choden-dev requested a review from asun555 August 1, 2024 08:21
@choden-dev choden-dev self-assigned this Aug 1, 2024
@choden-dev choden-dev force-pushed the format-booking-confirmation-dates-in-detail branch from 0559b87 to b292019 Compare August 1, 2024 08:22
Copy link

github-actions bot commented Aug 1, 2024

Visit the preview URL for this PR (updated for commit 26a820f):

https://uasc-ceebc--pr734-format-booking-confi-6un38vui.web.app

(expires Thu, 08 Aug 2024 09:04:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

Copy link
Contributor

@asun555 asun555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@choden-dev choden-dev merged commit 8065ae8 into master Aug 1, 2024
8 checks passed
@choden-dev choden-dev deleted the format-booking-confirmation-dates-in-detail branch August 1, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants