Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix videos on ios release #752

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix videos on ios release #752

merged 1 commit into from
Aug 7, 2024

Conversation

choden-dev
Copy link
Member

  • add playsInline attribute to video

  • only use webm as fallback

* add playsInline attribute to video

* only use webm as fallback
@choden-dev choden-dev requested a review from eddieyw August 7, 2024 04:15
Copy link

github-actions bot commented Aug 7, 2024

Visit the preview URL for this PR (updated for commit 737159b):

https://uasc-ceebc--pr752-master-x69v22ta.web.app

(expires Wed, 14 Aug 2024 04:18:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

Copy link
Contributor

@eddieyw eddieyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@choden-dev choden-dev merged commit 6fb2f3e into stable Aug 7, 2024
18 checks passed
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 04:39 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 05:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 08:38 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 09:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 10:38 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 11:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 12:54 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 13:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 15:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 16:42 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 17:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 18:40 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 19:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 20:37 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 21:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 22:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 7, 2024 23:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 01:46 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 02:49 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 03:37 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 04:39 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 05:37 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 06:41 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 08:39 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 09:35 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 10:38 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 11:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 12:54 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 13:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 14:35 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 17:35 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 18:41 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 19:37 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 20:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 21:37 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 22:37 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 8, 2024 23:36 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 9, 2024 01:47 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 9, 2024 02:49 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 9, 2024 03:37 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 9, 2024 04:38 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 9, 2024 05:37 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 9, 2024 08:39 — with GitHub Actions Inactive
@choden-dev choden-dev temporarily deployed to Client Production August 9, 2024 09:36 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants