Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up SSE (Server sent events) for event signup counts #776

Conversation

jeffplays2005
Copy link
Contributor

Created the getActiveEvents to fetch present events

Created the getActiveEvents to fetch present events
@jeffplays2005 jeffplays2005 linked an issue Sep 14, 2024 that may be closed by this pull request
7 tasks
Copy link

github-actions bot commented Sep 14, 2024

Visit the preview URL for this PR (updated for commit fd12ae5):

https://uasc-ceebc--pr776-662-backend-set-up-s-4abvz9gz.web.app

(expires Sun, 22 Sep 2024 03:01:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

…ethod that returns total count of reservations

Also did some documentation for methods that this method uses.

Created tests that are required
@jeffplays2005 jeffplays2005 marked this pull request as draft September 14, 2024 23:52
jeffplays2005 and others added 2 commits September 15, 2024 13:01
This endpoint creates a stream with keep-alive headers that continuously streams the number of active reservations.
@jeffplays2005
Copy link
Contributor Author

Note that this could probably do better than using just a Promise statement

image

Manual tests conducted:
image

(Note that the listener also correctly ends when the connection drops)

@jeffplays2005 jeffplays2005 marked this pull request as ready for review September 15, 2024 01:16
@choden-dev
Copy link
Member

also PR name

@jeffplays2005 jeffplays2005 changed the title Create getActiveEvents method in Event service and its tests Set up SSE (Server sent events) for event signup counts Sep 15, 2024
@jeffplays2005 jeffplays2005 merged commit 0a1f8c1 into master Sep 15, 2024
8 checks passed
@jeffplays2005 jeffplays2005 deleted the 662-backend-set-up-sse-server-sent-events-for-event-signup-counts branch September 15, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BACKEND] Set up SSE (Server sent events) for event signup counts
2 participants