Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

796 backend events endpoint only include forms url at given time #799

Conversation

AzizPatel786
Copy link
Contributor

No description provided.

…ponse if the current time is within 1 minute of the event start time.
@AzizPatel786 AzizPatel786 linked an issue Oct 6, 2024 that may be closed by this pull request
7 tasks
Copy link

github-actions bot commented Oct 6, 2024

Visit the preview URL for this PR (updated for commit 9cfec53):

https://uasc-ceebc--pr799-796-backend-events-e-8smu6ieh.web.app

(expires Wed, 23 Oct 2024 03:06:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

Copy link
Member

@choden-dev choden-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test is just a bit brittle right now

server/src/middleware/tests/EventController.test.ts Outdated Show resolved Hide resolved
server/src/service-layer/controllers/EventController.ts Outdated Show resolved Hide resolved
- Created a constant with a description
…orms-url-at-given-time

# Conflicts:
#	server/src/middleware/__generated__/swagger.json
#	server/src/service-layer/controllers/EventController.ts
Copy link
Member

@choden-dev choden-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this

@AzizPatel786 AzizPatel786 merged commit 1a2381d into master Oct 16, 2024
8 checks passed
@AzizPatel786 AzizPatel786 deleted the 796-backend-events-endpoint-only-include-forms-url-at-given-time branch October 16, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BACKEND] Change events endpoint to only include google forms URL at given time
2 participants