Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

805-frontend-display-all-events-to-admin #814

Merged
merged 11 commits into from
Oct 31, 2024
Merged

805-frontend-display-all-events-to-admin #814

merged 11 commits into from
Oct 31, 2024

Conversation

jeffplays2005
Copy link
Contributor

Draft

  • Created EventService.ts for fetching all events

@jeffplays2005
805-frontend-display-all-events-to-admin
2519cf3 
Initial commit

* Created EventService.ts for fetching all events
@jeffplays2005 jeffplays2005 linked an issue Oct 24, 2024 that may be closed by this pull request
[FRONTEND] Display all events to admin #805
Closed
6 tasks
@jeffplays2005 jeffplays2005 marked this pull request as draft October 24, 2024 00:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0abbd20):

https://uasc-ceebc--pr814-805-frontend-display-z9og8x5h.web.app

(expires Thu, 07 Nov 2024 10:56:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

@jeffplays2005
Copy link
Contributor Author

I'll need to refactor quite a bit so not ready for review yet.

@jeffplays2005
Fetch events in WrappedAdminEventView
a921b2a
@jeffplays2005
Center event items
08156b3
@jeffplays2005
Create variant for EventPreview
bac618d 
* Both regular and admin card

  * Regular is a thicker padding

  * Admin is a smaller padding
@jeffplays2005
Remove unneeded test file
49b7d50
@jeffplays2005
Document viewButtonText in EventPreview
213d6a2
@jeffplays2005
Update comment for AdminEventView
7a6ca90 
* Also remove `relative` from ReusableButtons as already exists
@jeffplays2005 jeffplays2005 marked this pull request as ready for review October 27, 2024 09:36
choden-dev
choden-dev reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@choden-dev choden-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, i think refactoring would be another ticket, just need to remove some of the unused code

client/src/components/generic/ReusableButtons/Button.tsx Outdated Show resolved Hide resolved
client/src/components/composite/Admin/AdminEventView/AdminAllEvents/AdminAllEvents.tsx Outdated Show resolved Hide resolved
client/src/components/composite/Admin/AdminEventView/AdminAllEvents/AdminAllEvents.tsx Show resolved Hide resolved
client/src/components/composite/Admin/AdminEventView/AdminEventView.tsx Show resolved Hide resolved
choden-dev
choden-dev approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@choden-dev choden-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but add screenshots to prove it works

@jeffplays2005
Copy link
Contributor Author

Pictures

  • Development server view:
Screenshot 2024-11-01 at 12 18 56 AM

Story book:

  • With events:
Screenshot 2024-11-01 at 12 19 33 AM
  • No events:
Screenshot 2024-11-01 at 12 19 38 AM

@jeffplays2005 jeffplays2005 merged commit 13817ab into master Oct 31, 2024
8 checks passed
@jeffplays2005 jeffplays2005 deleted the 805-frontend-display-all-events-to-admin branch October 31, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choden-dev choden-dev choden-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FRONTEND] Display all events to admin
2 participants
@jeffplays2005 @choden-dev