Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 764 changes to home page header #773

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

Wozunubi
Copy link
Contributor

Contribution:

Updated 2t4 logos for nav bar, home page. Updated images for home page carousel. Updated footer.

Issue:

Closes #764

Accomplishments:

  • 2t4 logo for navbar and home
  • new images for carousel
  • Should have white background behind home logo for visibility

Visuals:

Details:

Expected Behavior:

Testing Steps:

Complications:

  • Tried to clean up wall of import statements left by previous person, couldn't without slowing loading speed.

Resources:

Wozunubi added 2 commits June 13, 2024 17:27
Updated main page logo, navbar logo, and favicon logo to 2t4 unicorn. Increased height of navbar and size of navbar unicorn logo for better clarity. Added background for main page logo. Changed footer description from 2t3 to 2t4 tech team.
Main contributing factor to images not loading fast was content download time (~30s) rather than queuing or waiting for a response (2-3s). Hence set one image to always display first and compressed images
Copy link
Collaborator

@ashleyleal ashleyleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice choices of images for the carousel!

@ashleyleal ashleyleal merged commit 985a7bd into dev Jun 22, 2024
4 checks passed
@ashleyleal ashleyleal deleted the issue-764-changes-to-home-page-header branch June 22, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to Home Page Header
2 participants