Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seed to lfmcmc run function #30

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Add seed to lfmcmc run function #30

merged 4 commits into from
Nov 4, 2024

Conversation

apulsipher
Copy link
Contributor

Add optional seed parameter to LFMCMC run function to set the rand engine seed

@apulsipher apulsipher requested a review from gvegayon November 4, 2024 17:50
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.96%. Comparing base (884f49c) to head (af0f48d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   83.99%   83.96%   -0.03%     
==========================================
  Files          42       42              
  Lines        2761     2763       +2     
==========================================
+ Hits         2319     2320       +1     
- Misses        442      443       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gvegayon
Copy link
Member

gvegayon commented Nov 4, 2024

Please bump the patch version in epiworld.hpp one number up!

@apulsipher
Copy link
Contributor Author

Please bump the patch version in epiworld.hpp one number up!

@gvegayon I bumped the patch version, but see that it is failing the codecov/project check. What is this checking and how do I resolve that?

@gvegayon
Copy link
Member

gvegayon commented Nov 4, 2024

Please bump the patch version in epiworld.hpp one number up!

@gvegayon I bumped the patch version, but see that it is failing the codecov/project check. What is this checking and how do I resolve that?

Codecov checks for the delta in testing. Since you added a couple of lines, it is complaining that we have relatively less testing than in the master version. It's OK for the moment.

@gvegayon
Copy link
Member

gvegayon commented Nov 4, 2024

Oh, also please run the Make command that updates the single header. Thanks!

@apulsipher
Copy link
Contributor Author

Oh, also please run the Make command that updates the single header. Thanks!

Done

@gvegayon gvegayon merged commit 3ebd187 into master Nov 4, 2024
14 of 15 checks passed
@gvegayon gvegayon deleted the seed-patch branch November 4, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants