-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New example: MRSA community #32
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
=======================================
Coverage 83.96% 83.96%
=======================================
Files 42 42
Lines 2763 2763
=======================================
Hits 2320 2320
Misses 443 443 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this looks good! There are a few changes to make, and some of the automated checks are failing. Of the checks, the Doxygen check seems to be the biggest concern. Do we need to fix that test or is that something you can fix on this branch?
```bash | ||
root ➜ /workspaces/epiworld/examples/14-community-hosp (example-karim) $ make | ||
g++ -std=c++17 -O3 -g main.cpp -o main.o | ||
root ➜ /workspaces/epiworld/examples/14-community-hosp (example-karim) $ ./main.o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest updating this example to remove (example-karim)
for additional clarity
|
||
An few key observations from this example. | ||
|
||
1. **We have a sampling function that exclude population**. These two functions are used in the update functions so, when susceptible (in the community) sample, the sampling excludes individuals who are hospitalized. Likewise, hospitalized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This last sentence appears to be incomplete, or at least I'm not following it. "Likewise, hospitalized..." what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm addressing this in #34.
#include "../../epiworld.hpp" | ||
|
||
/*** | ||
* A concrete example would be a model that includes two populations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be reworded to "A concrete example with a model that includes two populations:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm addressing this in #34.
Closing this in favor of #34. |
This pull request includes several changes to the
epiworld
project, focusing on template parameter defaults, error message clarity, and the addition of a new community-hospital model example. The most important changes are summarized below:Template Parameter Defaults:
EPI_DEFAULT_TSEQ
as the default type forTSeq
instead ofint
. This change improves code consistency and flexibility. (epiworld.hpp
[1] [2] [3] [4];include/epiworld/agent-meat-virus-sampling.hpp
[5] [6] [7];include/epiworld/misc.hpp
[8]Error Message Clarity:
Model<TSeq>::operator()
method by adding single quotes around the parameter name. (epiworld.hpp
[1];include/epiworld/model-meat.hpp
[2]Community-Hospital Model Example:
Makefile
, a detailedREADME.md
, and a newmain.cpp
file with the model implementation. (examples/14-community-hosp/Makefile
[1];examples/14-community-hosp/README.md
[2];examples/14-community-hosp/main.cpp
[3]Makefile
to include the new community-hospital example. (examples/Makefile
examples/MakefileL11-R12)