-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix naming conventions in LFMCMC for consistency and clarity #37
Conversation
…ames, get_params_mean, get_stats_mean
…s, sampled_stats, sampled_accepted, accepted_params, accepted_stats
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 84.00% 84.00%
=======================================
Files 42 42
Lines 2769 2770 +1
=======================================
+ Hits 2326 2327 +1
Misses 443 443 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good so far
@gvegayon I made the fix to the LFMCMC print statement to include displaying the burn-in period. Also, I updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just ensure you compile the single header file under ./epiworld.hpp
. I think the Makefile
has a target for it.
This pull request introduces many variable and method name changes to the LFMCMC class. Generally, these changes include:
m_
prefix to member variables to improve understanding of variable usage