Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming conventions in LFMCMC for consistency and clarity #37

Merged
merged 15 commits into from
Dec 10, 2024

Conversation

apulsipher
Copy link
Contributor

This pull request introduces many variable and method name changes to the LFMCMC class. Generally, these changes include:

  • Adding the m_ prefix to member variables to improve understanding of variable usage
  • Renaming variables to more descriptive names
  • Renaming getters and setters to reflect member variable name
  • Cleaning up comments and organization of variables and methods

@apulsipher apulsipher linked an issue Dec 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 88.07339% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.00%. Comparing base (bb8d6e8) to head (b514bd3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
include/epiworld/math/lfmcmc/lfmcmc-meat.hpp 91.56% 7 Missing ⚠️
include/epiworld/math/lfmcmc/lfmcmc-meat-print.hpp 75.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files          42       42           
  Lines        2769     2770    +1     
=======================================
+ Hits         2326     2327    +1     
  Misses        443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@apulsipher apulsipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good so far

@apulsipher
Copy link
Contributor Author

@gvegayon I made the fix to the LFMCMC print statement to include displaying the burn-in period. Also, I updated set_stat_names and set_param_names as you request on the R side

Copy link
Member

@gvegayon gvegayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just ensure you compile the single header file under ./epiworld.hpp. I think the Makefile has a target for it.

@apulsipher apulsipher merged commit 2062297 into master Dec 10, 2024
13 checks passed
@apulsipher apulsipher deleted the 36-lfmcmc-naming-patch branch December 10, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix function naming conventions in LFMCMC
2 participants