Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename member variables and add new ones #45

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

apulsipher
Copy link
Contributor

@apulsipher apulsipher commented Dec 16, 2024

The PR introduces renames to several member variables and their associated getters to better reflect their functionality. In particular, this involves pre-pending the word "all" to variables that include data for multiple samples.

It also adds new member variables m_current_proposed_stats and m_current_accepted_stats with getters and updates them accordingly in the run() function.

@apulsipher apulsipher linked an issue Dec 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.08%. Comparing base (e673f04) to head (f7f3ab5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   84.03%   84.08%   +0.04%     
==========================================
  Files          42       42              
  Lines        2775     2783       +8     
==========================================
+ Hits         2332     2340       +8     
  Misses        443      443              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apulsipher apulsipher requested a review from gvegayon December 16, 2024 19:24
Copy link
Member

@gvegayon gvegayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments: make sure that the functions you added/edited that don't modify the class have the const suffix. Thank you!

include/epiworld/math/lfmcmc/lfmcmc-bones.hpp Outdated Show resolved Hide resolved
include/epiworld/math/lfmcmc/lfmcmc-bones.hpp Outdated Show resolved Hide resolved
@apulsipher
Copy link
Contributor Author

@gvegayon I just added the const suffix as you requested. Is it good to merge now?

@gvegayon gvegayon merged commit b9c7ed3 into master Dec 16, 2024
13 of 14 checks passed
@gvegayon gvegayon deleted the 44-renaming-patch branch December 16, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename variables and add new getters
2 participants