Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 포인트 전체 내역 조회 페이징 수정 #200

Merged
merged 5 commits into from
Jan 27, 2024
Merged

fix: 포인트 전체 내역 조회 페이징 수정 #200

merged 5 commits into from
Jan 27, 2024

Conversation

decten
Copy link
Contributor

@decten decten commented Jan 27, 2024

💡Motivation

  • 전체 내역 조회에서 pagenation이 적용이 안 돼서 해결했습니다

📌Changes

image

🫱🏻‍🫲🏻To Reviewers

  • Page, PageImpl 모두 확인 했는데 기존 페이지에 추가 하는 메서드가 없어서, 페이지로 이뤄진 걸 list로 바꾸고 새로 합산해서 새로 페이지를 만들었습니다

@decten decten added the 🧑🏻‍🔧fix 오류 수정 label Jan 27, 2024
@decten decten self-assigned this Jan 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2024 •
edited
Loading

Test Results

99 tests   93 ✅  4s ⏱️
61 suites   6 💤
61 files     0 ❌

Results for commit d031176.

♻️ This comment has been updated with latest results.

JeongUijeong
JeongUijeong approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@JeongUijeong JeongUijeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@JeongUijeong JeongUijeong merged commit db2bd8a into develop Jan 27, 2024
3 checks passed
@decten decten deleted the bugfix/totalPageable branch January 27, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongUijeong JeongUijeong JeongUijeong approved these changes

@chaewon12 chaewon12 Awaiting requested review from chaewon12

@matrixpower1004 matrixpower1004 Awaiting requested review from matrixpower1004

Assignees

@decten decten

Labels
🧑🏻‍🔧fix 오류 수정
Projects
BE 2차 스프린트
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@decten @JeongUijeong