refactor: 포인트와 숙소 가독성 개선 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/backoffice/upjuyanolja/domain/accommodation/service/AccommodationCommandService.java # src/main/java/com/backoffice/upjuyanolja/domain/point/service/PointService.java # src/main/java/com/backoffice/upjuyanolja/domain/room/service/RoomCommandService.java # src/test/java/com/backoffice/upjuyanolja/domain/room/unit/service/RoomCommandServiceTest.java
decten
requested review from
chaewon12,
gahyuun,
JeongUijeong and
matrixpower1004
Test Results100 tests 94 ✅ 5s ⏱️ Results for commit 8192642. ♻️ This comment has been updated with latest results. |
chaewon12
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡Motivation
📌Changes
🫱🏻🫲🏻To Reviewers
지금 제가 개발한 api에서 couponName까지 제대로 나오고 있는데
https://fast-catch-front-end-gold.vercel.app/
홈페이지에서는 쿠폰 정보가 안 나오고 있습니다, 쿠폰 값이 이상해서 프런트에서 뺐는지 아니면 서버에서 못 받고 있는지 내일 여쭤보려고 합니다
-> 쿠폰 테이블에 데이터 추가함으로써 해결(미니프 숙소는 쿠폰 테이블만 접근하고 coupon-issuance 사용 안 함)