-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osmox #40
Merged
Merged
osmox #40
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5348f01
adding osmox config
Hussein-Mahfouz 34c8246
Merge branch 'main' into osmox
sgreenbury 7e418f0
Add script for osmox
sgreenbury 8bb6df5
Use geoparquet instead of geopackage
sgreenbury d929530
Update script output paths
sgreenbury f4ce403
Add osmox script to pipeline
sgreenbury b54cff0
Add osmium deps to CI
sgreenbury 1504c59
Fix pbf filepath for osmox
sgreenbury File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,180 @@ | ||
{ | ||
"filter": { | ||
"building": [ | ||
"apartments", | ||
"bungalow", | ||
"detached", | ||
"dormitory", | ||
"hotel", | ||
"house", | ||
"residential", | ||
"semidetached_house", | ||
"terrace", | ||
"commercial", | ||
"retail", | ||
"supermarket", | ||
"industrial", | ||
"office", | ||
"warehouse", | ||
"bakehouse", | ||
"firestation", | ||
"government", | ||
"cathedral", | ||
"chapel", | ||
"church", | ||
"mosque", | ||
"other", | ||
"shrine", | ||
"synagogue", | ||
"temple", | ||
"hospital", | ||
"kindergarden", | ||
"school", | ||
"university", | ||
"college", | ||
"sports_hall", | ||
"stadium", | ||
"yes" | ||
], | ||
"public_transport": ["*"], | ||
"highway": ["bus_stop"] | ||
}, | ||
|
||
"object_features": ["units", "levels", "area", "floor_area"], | ||
|
||
"distance_to_nearest": ["transit", "shop", "medical"], | ||
|
||
"default_tags": [["building", "residential"]], | ||
|
||
"activity_mapping": { | ||
"public_transport": { | ||
"*": ["transit"] | ||
}, | ||
"highway": { | ||
"bus_stop": ["transit"] | ||
}, | ||
"building": { | ||
"apartments": ["home"], | ||
"bungalow": ["home"], | ||
"detached": ["home"], | ||
"dormitory": ["home"], | ||
"hotel": ["home"], | ||
"house": ["home"], | ||
"residential": ["home"], | ||
"semidetached_house": ["home"], | ||
"terrace": ["home"], | ||
"commercial": ["shop", "work"], | ||
"retail": ["shop", "work"], | ||
"supermarket": ["shop", "work"], | ||
"industrial": ["work"], | ||
"office": ["work"], | ||
"warehouse": ["work"], | ||
"bakehouse": ["work"], | ||
"firestation": ["work"], | ||
"government": ["work"], | ||
"cathedral": ["other"], | ||
"chapel": ["other"], | ||
"church": ["other"], | ||
"mosque": ["other"], | ||
"other": ["other"], | ||
"shrine": ["other"], | ||
"synagogue": ["other"], | ||
"temple": ["other"], | ||
"hospital": ["medical", "work"], | ||
"kindergarden": ["education_kg", "work"], | ||
"school": ["education_school", "work"], | ||
"university": ["education_university", "work"], | ||
"college": ["education_college", "work"], | ||
"sports_hall": ["other", "work"], | ||
"stadium": ["other", "work"] | ||
}, | ||
"amenity": { | ||
"bar": ["visit", "work"], | ||
"pub": ["visit", "work"], | ||
"cafe": ["visit", "work", "shop"], | ||
"fast_food": ["work", "shop"], | ||
"food_court": ["work", "shop"], | ||
"ice_cream": ["work", "shop"], | ||
"restaurant": ["work", "shop"], | ||
"college": ["education_college", "work"], | ||
"kindergarten": ["education_kg", "work"], | ||
"language_school": ["education_school", "work"], | ||
"library": ["other", "work"], | ||
"music_school": ["education_school", "work"], | ||
"school": ["education_school", "work"], | ||
"university": ["education_university", "work"], | ||
"bank": ["other", "work"], | ||
"clinic": ["medical", "work"], | ||
"dentist": ["medical", "work"], | ||
"doctors": ["medical", "work"], | ||
"hospital": ["medical", "work"], | ||
"pharmacy": ["shop", "work"], | ||
"visit_facility": ["medical", "work"], | ||
"vetinary": ["other", "work"], | ||
"arts_centre": ["other", "work"], | ||
"casino": ["other", "work"], | ||
"cinema": ["other", "work"], | ||
"community_centre": ["other"], | ||
"gambling": ["other", "work"], | ||
"studio": ["other", "work"], | ||
"theatre": ["other", "work"], | ||
"courthouse": ["other", "work"], | ||
"crematorium": ["other", "work"], | ||
"embassy": ["other", "work"], | ||
"fire_station": ["work"], | ||
"funeral_hall": ["other", "work"], | ||
"internet_cafe": ["other", "work"], | ||
"marketplace": ["shop", "work"], | ||
"place_of_worship": ["other"], | ||
"police": ["other", "work"], | ||
"post_box": ["other", "work"], | ||
"post_work": ["other", "work"], | ||
"post_office": ["other", "work"], | ||
"prison": ["other", "work"], | ||
"townhall": ["other", "work"] | ||
}, | ||
"healthcare": { | ||
"*": ["medical", "work"] | ||
}, | ||
"landuse": { | ||
"commercial": ["shop", "work"], | ||
"industrial": ["work"], | ||
"residential": ["home"], | ||
"retail": ["shop", "work"], | ||
"work": ["work"], | ||
"port": ["work"], | ||
"quary": ["work"], | ||
"other": ["other"] | ||
}, | ||
"other": { | ||
"adult_gaming_centre": ["other", "work"], | ||
"amusement_arcade": ["other", "work"], | ||
"beach_resort": ["other"], | ||
"dance": ["other", "work"], | ||
"escape_game": ["other", "work"], | ||
"fishing": ["other"], | ||
"fitness_centre": ["other", "work"], | ||
"fitness_station": ["other"], | ||
"garden": ["other"], | ||
"horse_riding": ["other", "work"], | ||
"ice_rink": ["other", "work"], | ||
"marina": ["other", "work"], | ||
"miniature_golf": ["other"], | ||
"nature_reserve": ["other"], | ||
"park": ["other"], | ||
"pitch": ["other"], | ||
"playground": ["other"], | ||
"sports_centre": ["other", "work"], | ||
"stadium": ["other", "work"], | ||
"swimming_pool": ["other", "work"], | ||
"track": ["other"], | ||
"water_park": ["other", "work"] | ||
}, | ||
"office": { | ||
"*": ["work"] | ||
}, | ||
"shop": { | ||
"*": ["shop", "work"] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
- filter: which POIs to keep | ||
|
||
- object_features: which features to retain | ||
- can I retain isced to distinguish between primary and secondary schools? See here: https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dschool | ||
|
||
- distance to nearest: list that can include any of the activities that you have included in activity mapping. e.g.: ["transit", "education", "shop", "medical"], | ||
|
||
- fill_missing_activities: only include if you want to fill missing activities |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can move these osmox notes to a section in the documentation as part of #63?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to add the notes as a subsection under the Installation section of the main README? If that sounds good, do you mind doing it? I think you're better placed to add the notes than I am.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll go ahead and add these notes to the docs as part of #63. I think we can have a section on configuration of the pipeline and we can include a subsection on osmox and mention the default config file JSON (
config_osmox.json
) along with the descriptions here.