Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind context to async execution avoiding race-conditions #2521

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

enisdenjo
Copy link
Collaborator

Like when using graphql-modules with an HTTP server.

Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: 0491f4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-modules Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 23, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
graphql-modules 2.4.1-alpha-20250121160438-0491f4c48e11d9b869a28a3d5dc1f2c339cfdb5c npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Dec 23, 2024

💻 Website Preview

The latest changes are available as preview in: https://8faf6ca0.graphql-modules.pages.dev

@Intellicode
Copy link
Contributor

@enisdenjo thanks for fixing this! Is there anything blocking preventing this to be released?

@ardatan
Copy link
Collaborator

ardatan commented Jan 20, 2025

You dont have to wait.
You can start using the alphas here
#2521 (comment)

@enisdenjo
Copy link
Collaborator Author

@Intellicode there are some benchmarks that got degraded due to this change (which is expected since async_hooks do slow down the execution), there's also removing the dependency on Node (both module and async_hooks cant be imported on root).

Then this can land.

@Intellicode
Copy link
Contributor

You dont have to wait. You can start using the alphas here #2521 (comment)

We indeed tested the alpha build to confirm the absence of the race condition (in our setup), however for production usage it would be nice to have an official release if possible.

@Intellicode there are some benchmarks that got degraded due to this change (which is expected since async_hooks do slow down the execution), there's also removing the dependency on Node (both module and async_hooks cant be imported on root).

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants