-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind context to async execution avoiding race-conditions #2521
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0491f4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
💻 Website PreviewThe latest changes are available as preview in: https://8faf6ca0.graphql-modules.pages.dev |
@enisdenjo thanks for fixing this! Is there anything blocking preventing this to be released? |
You dont have to wait. |
@Intellicode there are some benchmarks that got degraded due to this change (which is expected since async_hooks do slow down the execution), there's also removing the dependency on Node (both Then this can land. |
We indeed tested the alpha build to confirm the absence of the race condition (in our setup), however for production usage it would be nice to have an official release if possible.
Thanks for the update! |
Like when using graphql-modules with an HTTP server.