Support more naming conventions for symbol names #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added conventions: - camel_Snake_Case (camelCase_Then_PascalCase) - underscoreSeparated_camelCase - Pascal_Snake_Case (UnderscoreSeparated_PascalCase) - flatcase - UPPERFLATCASE
Pascal_Snake_Case allows multiple underscore-delimited PascalCase parts, and is a superset of PascalCase. Some other sources use symbol names more like this than strict PascalCase, so loosen the restrictions to better accommodate them.
UsernameFodder
force-pushed
the
case-conventions
branch
from
eaf45c7 to
3027f16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some other sources use symbol names with hybrid naming conventions. Add support for a few more sensible conventions in
resymgen, and loosen the restrictions for pmdsky-debug function names to includePascal_Snake_Case(multiple underscore-delimitedPascalCaseparts).Support for the following new naming conventions has been added to
resymgenfor general use:camel_Snake_Case(camelCase_Then_PascalCase)underscoreSeparated_camelCasePascal_Snake_Case(UnderscoreSeparated_PascalCase)flatcaseUPPERFLATCASE