-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yda 5942 add user friendly messages csv import #522
Merged
stsnel
merged 25 commits into
development
from
YDA-5942-add-user-friendly-messages-csv-import
Oct 1, 2024
Merged
Yda 5942 add user friendly messages csv import #522
stsnel
merged 25 commits into
development
from
YDA-5942-add-user-friendly-messages-csv-import
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonidastri
deleted the
YDA-5942-add-user-friendly-messages-csv-import
branch
September 12, 2024 12:00
leonidastri
restored the
YDA-5942-add-user-friendly-messages-csv-import
branch
September 12, 2024 12:01
…s://github.com/UtrechtUniversity/yoda-ruleset into YDA-5942-add-user-friendly-messages-csv-import
stsnel
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general 👍, I've added a few comments regarding some minor things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When modifying groups with a CSV, I use groups that are already created (to add users for example) . I check the “Allow updates” button and “Process CSV”. I then get an error for existing groups even though the users have been added
Solution
When import groups using a CSV file, now the user can be informed with a simple, but useful descriptive message of the actions taken:
A message may consist of 1 or more of the following phrases:
This should be merge taking into account the following PR also
UtrechtUniversity/yoda-portal#362