[modulite] fixed inheritance late static bindings #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidanio
changed the title
Hidanio
force-pushed
the
hidanjkezor/inheritance_late_static_bindings_fix
branch
4 times, most recently
from
a8e03e9
to
d844db9
Compare
Hidanio
force-pushed
the
hidanjkezor/inheritance_late_static_bindings_fix
branch
2 times, most recently
from
83044ed
to
c5e7e69
Compare
…s, but trying to be required in derived too Added test for case when we have class(1) inside function of another class(2) that is parent class(2) for another (3), but (1) trying to be required in (3) Added test for late static binding
updated comments for case2 in modulite-check-rules
tolk-vm
force-pushed
the
hidanjkezor/inheritance_late_static_bindings_fix
branch
from
2d1067a
to
11741ee
Compare
tolk-vm
changed the title
tolk-vm
approved these changes
Oct 18, 2023
Hidanio
added a commit
that referenced
this pull request
Oct 23, 2023
* added new tests for late static bindings in modulite * fixed logic when modulite not correctly handles late static binding with cross-module inheritance --------- Co-authored-by: Aleksandr Kirsanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new test cases for late static bindigs
Fixed some issues with late static bindigs
Also added pull requests in modulite-phpstan and modulite