add non function union body

VKCOM · Dec 10, 2024 · e71c8f6 · e71c8f6
1 parent a77527d
commit e71c8f6
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 6 deletions.
diff --git a/internal/tlcodegen/tlgen.go b/internal/tlcodegen/tlgen.go
@@ -1217,13 +1217,14 @@ func GenerateCode(tl tlast.TL, options Gen2Options) (*Gen2, error) {
 			return nil, err
 		}
 	case "php":
-		if gen.copyrightText == "" {
-			gen.copyrightText = `
-/**
+		{
+			// TODO ADD FEATURE TO CHANGE IT
+			gen.copyrightText = `/**
  * AUTOGENERATED, DO NOT EDIT! If you want to modify it, check tl schema.
  *
  * This autogenerated code represents tl class for typed RPC API.
  */
+
 `
 		}
 		if err := gen.generateCodePHP(generateByteVersions); err != nil {

diff --git a/internal/tlcodegen/type_rw_struct.go b/internal/tlcodegen/type_rw_struct.go
@@ -603,8 +603,10 @@ func (trw *TypeRWStruct) PhpTypeName(withPath bool) string {
 }
 
 func (trw *TypeRWStruct) PhpGenerateCode(code *strings.Builder, bytes bool) error {
-	code.WriteString(`use VK\TL;
-
+	if isUsingTLImport(trw) {
+		code.WriteString("\nuse VK\\TL;\n")
+	}
+	code.WriteString(`
 /**
  * @kphp-tl-class
  */
@@ -692,7 +694,7 @@ func (trw *TypeRWStruct) PhpGenerateCode(code *strings.Builder, bytes bool) erro
 
 	code.WriteString(") {\n")
 	for _, f := range necessaryFieldsInConstructor {
-		code.WriteString(fmt.Sprintf("    $this->$%[1]s = $%[1]s;\n", f.originalName))
+		code.WriteString(fmt.Sprintf("    $this->%[1]s = $%[1]s;\n", f.originalName))
 	}
 	code.WriteString("  }\n")
 
@@ -764,6 +766,16 @@ func (trw *TypeRWStruct) PhpGenerateCode(code *strings.Builder, bytes bool) erro
 	return nil
 }
 
+func isUsingTLImport(trw *TypeRWStruct) bool {
+	for _, field := range trw.Fields {
+		fieldType, _ := fieldTypeAndDefaultValue(field)
+		if strings.Contains(fieldType, "TL\\") {
+			return true
+		}
+	}
+	return false
+}
+
 func fieldTypeAndDefaultValue(f Field) (string, string) {
 	fieldType := f.t.trw.PhpTypeName(true)
 	defaultValue := f.t.trw.PhpDefaultValue()

diff --git a/internal/tlcodegen/type_rw_union.go b/internal/tlcodegen/type_rw_union.go
@@ -215,6 +215,30 @@ func (trw *TypeRWUnion) PhpTypeName(withPath bool) string {
 }
 
 func (trw *TypeRWUnion) PhpGenerateCode(code *strings.Builder, bytes bool) error {
+	classes := make([]string, len(trw.Fields))
+	for i, field := range trw.Fields {
+		classes[i] = fmt.Sprintf("%s::class", field.t.trw.PhpClassName(true))
+	}
+
+	code.WriteString(`use VK\TL;
+
+/**
+ * @kphp-tl-class
+ */
+`)
+	code.WriteString(fmt.Sprintf(
+		`interface %[1]s {
+
+  /** Allows kphp implicitly load all available constructors */
+  const CONSTRUCTORS = [
+	%[2]s
+  ];
+
+}
+`,
+		trw.PhpClassName(false),
+		strings.Join(classes, ",\n    "),
+	))
 	return nil
 }