Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMS support for PR #351 #360

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Fix CMS support for PR #351 #360

merged 6 commits into from
Dec 21, 2023

Conversation

jalsol
Copy link
Collaborator

@jalsol jalsol commented Dec 5, 2023

Description

Type of change: bug fix

What

Fix CMS support by including another regex. Also, change the method of getting the file name to test.

Why

The old regex supported CMS. The current tests fail in this case (i.e. both CMS input and output files are recognized as Polygon input files).

How Has This Been Tested?

Tested on local version of VNOJ, including previous tests and a Free Contest test data (in: CLIMBING/input.*, out: CLIMBING/output.*).

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the README/documentation
  • Any dependent changes have been merged and published in downstream modules
  • Informed of breaking changes, testing and migrations (if applicable).
  • Attached screenshots (if applicable).

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

@jalsol jalsol closed this Dec 5, 2023
@jalsol jalsol reopened this Dec 5, 2023
@jalsol jalsol marked this pull request as draft December 5, 2023 00:32
@jalsol jalsol marked this pull request as ready for review December 5, 2023 00:36
Copy link
Contributor

@leduythuccs leduythuccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leduythuccs leduythuccs merged commit 921f209 into master Dec 21, 2023
6 checks passed
@leduythuccs leduythuccs deleted the fix-test-upload-regex branch December 21, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants