Add a table in problem view to switch problems #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leduythuccs
reviewed
Dec 5, 2023
templates/problem/problem.html
Outdated
Comment on lines
352
to
357
| {% if can_view_all_problems or problem.is_public %} | ||
| <a href="{{ url('problem_detail', contest_problem.code) }}"> | ||
| {{contest.get_label_for_problem(loop.index0)}} | ||
| </a> | ||
| {% else %} | ||
| {{contest.get_label_for_problem(loop.index0)}} |
There was a problem hiding this comment.
for in-contest problems, they are not public, so the check will always be false, aka the link is not show -> useless
leduythuccs
reviewed
Dec 5, 2023
judge/views/problem.py
Outdated
Comment on lines
206
to
213
| context['contest_problems'] = Problem.objects.filter(contests__contest=contest_problem.contest) \ | ||
| .order_by('contests__order').defer('description') \ | ||
| .annotate(has_public_editorial=Case( | ||
| When(solution__is_public=True, solution__publish_on__lte=timezone.now(), then=True), | ||
| default=False, | ||
| output_field=BooleanField(), | ||
| )) \ | ||
| .add_i18n_name(self.request.LANGUAGE_CODE) |
There was a problem hiding this comment.
the query is kinda heavy and we don't need all this infformation
leduythuccs
added a commit
that referenced
this pull request
Oct 18, 2024
* Add a table to switch to problems * optimize query --------- Co-authored-by: Le Duy Thuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change: new feature
What
Why
Requested by last year's contestants.
How Has This Been Tested?
Tested on local version of VNOJ.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.