Initial commit #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
commented
Dec 31, 2024
| @@ -0,0 +1 @@ | |||
| dist/*.js linguist-generated binary | |||
There was a problem hiding this comment.
gitのdiffが鬱陶しかったのでbinary扱いにしています。
| @@ -0,0 +1 @@ | |||
| 20.18.1 | |||
There was a problem hiding this comment.
Actionで使えるのがnode20までだったので20で止めています。
Hiroshiba
reviewed
Dec 31, 2024
| export type ScoreRule = { | ||
| target: "team" | "user"; | ||
| slug: string; | ||
| users: string[]; |
There was a problem hiding this comment.
targetがuserのときはusersじゃなくuserのが良いかも。Union型にする感じで。
…とか思ったけどちょっと気にしすぎですかね！まあそのままでも！
Hiroshiba
approved these changes
Dec 31, 2024
Comment on lines
+42
to
+49
| score_rules: | | ||
| // チームの場合は#から始めてください。 | ||
| #maintainer: 2 | ||
| #reviewer: 1 | ||
| // ユーザーの場合は@から始めてください。 | ||
| @sevenc-nanashi: 2 | ||
| // それ以外の行は無視されます。 |
There was a problem hiding this comment.
そういえば今の仕様だと同じユーザーが複数チームやユーザー指定されていた場合、ここに書かれてる中でヒットした最初のチームのポイントが選ばれて、ユーザー指定されてる場合は更にそちらが優先される感じになりますかね？
どこかに仕様をメモっておいても良いかも！
|
そういえば現時点でちゃんと動くかどうか確認したい気持ちがあります。 @Hiroshiba 多分これらをやれば動くと思います：
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
https://github.com/sevenc-nanashi/approve-counter から持ってきます。
関連 Issue
スクリーンショット・動画など
（なし）
その他
（なし）