fix(ci)!: bump Rust, bump bindgen to v0.70.1, and drop macos-12
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Sep 26, 2024
Comment on lines
-41
to
+43
| Err(unsafe { std::mem::transmute(result) }) | ||
| Err(unsafe { | ||
| std::mem::transmute::<open_jtalk_sys::text2mecab_result_t, Text2MecabError>(result) | ||
| }) |
There was a problem hiding this comment.
本当はstd::mem::transmute自体置き換えたいけど、とりあえず今回はClippyを黙らせるだけ。
|
何だろう？bindgenがエラーなく空っぽの.rsを吐き出してる？CMakeかClangあたりかな... |
|
実際空っぽじゃないけど、なんか破壊されていた |
Co-authored-by: qryxip <[email protected]>
Co-authored-by: qryxip <[email protected]>
Co-authored-by: qryxip <[email protected]>
Co-authored-by: qryxip <[email protected]>
Co-authored-by: qryxip <[email protected]>
Co-authored-by: qryxip <[email protected]>
Co-authored-by: qryxip <[email protected]>
Co-authored-by: qryxip <[email protected]>
Co-authored-by: qryxip <[email protected]>
Co-authored-by: qryxip <[email protected]>
|
なんかbindgenを最新まで上げたら大丈夫だった。 |
Hiroshiba
approved these changes
Oct 14, 2024
|
あ、そういえばマージ権限が無いですね。 |
|
ほんとだ！ 権限つけられたと思います！ |
|
そういえばこのPRのことを忘れてました。マージボタンはまだ現れてません。これについての設定は確かbranch protection周りだった記憶があります。
この二ヶ月でRust 1.83が出て、 |
|
あっすみませんでした！！ 変更しました 🙇 🙇 🙇 |
qryxip
changed the title
macos-12 to fix the CI
|
|
qryxip
changed the title
macos-12 to fix the CImacos-12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
関連 Issue
スクリーンショット・動画など
その他