Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

マルチエンジン：ZIP64の展開を修正 #1162

Merged
merged 5 commits into from
Feb 17, 2023
Merged

マルチエンジン：ZIP64の展開を修正 #1162

merged 5 commits into from
Feb 17, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

Zip64のVVPPの展開に失敗するバグを修正します。

関連 Issue

ref: VOICEVOX/voicevox_project#2 (comment)

スクリーンショット・動画など

（なし）

その他

（なし）

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner January 31, 2023 09:14
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team January 31, 2023 09:14
Hiroshiba
Hiroshiba reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！

unzipperがなぜgithubからのインストールになっているのかコメントを残しておきたいかもです。
でもpackage.jsonはコメントができない･･･

ので、import unzipperしてるところにFIXMEコメントとこのPRのURLを書くのとかどうでしょう 👀

@sevenc-nanashi
Copy link
Member Author

レビューの部分を修正しましたー。

Hiroshiba
Hiroshiba approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@sevenc-nanashi
Copy link
Member Author

（このPRってどうなってます？）

y-chan
y-chan approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです、レビューが足りてなくてマージできてないだけかも...!
マージしますね...!

@y-chan y-chan merged commit 3a53442 into VOICEVOX:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-chan y-chan y-chan approved these changes

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevenc-nanashi @Hiroshiba @y-chan