Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[project-library-manage] 音声ライブラリの最新バージョン判定の誤りを修正 #1562

Merged
merged 1 commit into from
Sep 17, 2023
Merged

[project-library-manage] 音声ライブラリの最新バージョン判定の誤りを修正 #1562

merged 1 commit into from
Sep 17, 2023

Conversation

y-chan
Copy link
Member

@y-chan y-chan commented Sep 17, 2023

内容

題のとおりです。頭が混乱していたのか、判定を誤っていたので修正しました。
ついでに、頭がこんがらがらないようにコメントを追記しました。

その他

#1560 を適用しないと、sharevox engineによるUIでの確認ができません。

@y-chan y-chan requested a review from a team as a code owner September 17, 2023 08:24
@y-chan y-chan requested review from Hiroshiba and removed request for a team September 17, 2023 08:24
@y-chan y-chan changed the title [project-library-manage]音声ライブラリの最新バージョン判定の誤りを修正 [project-library-manage] 音声ライブラリの最新バージョン判定の誤りを修正 Sep 17, 2023
Hiroshiba
Hiroshiba approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！
テストがあるとさらに安心できるかもですねぇ😇

@Hiroshiba Hiroshiba merged commit eca2d28 into VOICEVOX:project-library-manage Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-chan @Hiroshiba