Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[project-sequencer-statemachine] ResizeNoteLeftStateを追加 #2463

Merged
merged 5 commits into from
Jan 3, 2025
Merged

[project-sequencer-statemachine] ResizeNoteLeftStateを追加 #2463

merged 5 commits into from
Jan 3, 2025

Conversation

sigprogramming
Copy link
Contributor

内容

以下を行います。

  • ResizeNoteLeftStateを追加
  • リファクタリング

関連 Issue

その他

@sigprogramming sigprogramming requested a review from a team as a code owner January 3, 2025 01:23
@sigprogramming sigprogramming requested review from Hiroshiba and removed request for a team January 3, 2025 01:23
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Jan 3, 2025 •
edited
Loading

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ：796fc9f

@Hiroshiba Hiroshiba requested a review from Copilot January 3, 2025 06:03
Copilot
Copilot AI reviewed Jan 3, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Hiroshiba
Hiroshiba reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

たぶんほぼLGTMです！！
テストが欲しくなってきますね･･･！

実際にResizeNoteLeftStateを使っているコードがまだ無いけど大丈夫でしょうか？
以前までのはあった記憶があるので聞いてみてるだけです！
後で追加するとかでも全然良さそう！

src/sing/stateMachine/sequencerStateMachine.ts Outdated Show resolved Hide resolved
src/sing/stateMachine/sequencerStateMachine.ts Outdated Show resolved Hide resolved
@sigprogramming
Copy link
Contributor Author

実際にResizeNoteLeftStateを使っているコードがまだ無いけど大丈夫でしょうか？

一部だけ置き換えるのが難しいので、一通り実装してから置き換えを考えています！

Hiroshiba
Hiroshiba approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@Hiroshiba Hiroshiba merged commit 07783fb into VOICEVOX:project-sequencer-statemachine Jan 3, 2025
10 checks passed
@sigprogramming sigprogramming deleted the add_resize_note_left_state branch January 5, 2025 03:28
@sigprogramming sigprogramming mentioned this pull request Dec 20, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigprogramming @Hiroshiba