Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: vvppManager.extractVvppの処理を関数切り出し #2478

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Jan 5, 2025

内容

vvppManagerのextractVvppの処理を関数切り出しします。

のタスクの

デフォルトエンジンと同じIDを持つvvppをインストールできないようにする

をする前準備です。
ちょっと関数切り出ししないとこのメソッドがどういう経路で何をやっているか分かりにくかったので、出してみました。

関連 Issue

その他

大半がコードの移動です。リファクタリングとかも意識してやってないです。

git diff -w --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space df4ad342c0f62eadeae1819eaf55c249307626aa

すると差分が分かりやすいはず!

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 5, 2025 17:27
@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:ea7db0f

@Hiroshiba Hiroshiba requested a review from Copilot January 5, 2025 17:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/backend/electron/manager/vvppManager.ts:254

  • [nitpick] The error message 'Unknown file format: ${archiveFileParts[0]}' could be more descriptive. Consider updating it to 'Unsupported file format detected for file: ${archiveFileParts[0]}. Supported formats are zip and 7z.'
throw new Error(`Unknown file format: ${archiveFileParts[0]}`);
@Hiroshiba
Copy link
Member Author

ChatGPTさんのレビューも問題なさそう。
https://chatgpt.com/share/677ac35b-3ad8-8008-8fdf-10ae11149d2f

@Hiroshiba
Copy link
Member Author

ちょっとあまりリファクタリングの経験がなく、この関数切り出しが妥当なのかどうかわからないのですが、まあでも問題にはならなさそうなのと後続のタスクができないのとで、マージしたいと思います!

@Hiroshiba Hiroshiba enabled auto-merge January 7, 2025 16:21
@Hiroshiba Hiroshiba added this pull request to the merge queue Jan 7, 2025
Merged via the queue into VOICEVOX:main with commit 10ce8de Jan 7, 2025
11 checks passed
@Hiroshiba Hiroshiba deleted the 20250106-022745 branch January 7, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant