[project-sequencer-statemachine] ファイルを分けて整理 #2504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprogramming
requested review from
Hiroshiba
and removed request for
a team
sigprogramming
commented
Jan 24, 2025
Comment on lines
+88
to
92
| type StateFactories<T extends StateDefinition[], Input, Context> = { | ||
| [U in StateId<T>]: ( | ||
| args: FactoryArgs<T, U>, | ||
| ) => State<T, Input, Context> & { readonly id: U }; | ||
| }; |
There was a problem hiding this comment.
型引数U extends StateId<T>は無くても良さそうだったので無くしました。
（変更はこのファイルのみです）
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Hiroshiba
reviewed
Jan 24, 2025
src/components/Sing/sequencerStateMachine/states/addNoteState.ts
Outdated
Show resolved
Hide resolved
Hiroshiba
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
LGTM！！
ちょっとこちら都合なのですが、sequencerStateMachine/useSequencerStateMachine.tsをuseSequencerStateMachine/index.tsに変えさせていただこうと思います 🙇
こうするとこのコンポーザブルをインポートする時に
import { useSequencerStateMachine } from "@/composables/useSequencerStateMachine"で行けるようになって、ディレクトリが透過？されて見た目は普通の関数ファイルと一緒になるから、使い手側に便利かなと･･･！
あとファイル整理して気づいたんですが、useSequencerStateMachineから使われるstatesとかはsrc/sing/SequencerStateMachineとかに配置しても良いかもと思いました。
コンポーザブルはそのステートマシンのVue用のインターフェースを提供するだけみたいな！
一旦今のままでも大丈夫ですし、そちらに変更もありだと思います！
コメントお待ちして、今のままでも大丈夫そうならマージさせていただこうと思います！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ファイルを分けて整理します。
StateFactoriesのみ少し変更しています。（処理の変更はここのみで、あとは移動のみ行っています）関連 Issue
その他