[project-vvm-async-api] Fix up #500 #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#516 (comment)のやつです。
使わなくなった
memorize_static_strを削除して代わりに定数であるvoicevox_versionのみに反応するようにする、というのを元々考えていました。ただよく考えたら定数をfreeしようとする人は多分いないし、 あと #500 のときに忘れていたけど
voicevox_error_result_to_messageに対してmemorize_static_strの出番があるはず、ということでこのようになりました。関連 Issue
char*の解放を明示的に拒否する #500その他
このPRはmainの方に出すべきかもしれませんが、またマージするのも面倒だろうしこっちでいいかなと思いました。