Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ダウンローダーに--only <TARGET>...と--exclude <TARGET>...を追加 #647

Merged
merged 6 commits into from
Oct 15, 2023
Merged

ダウンローダーに--only <TARGET>...と--exclude <TARGET>...を追加 #647

merged 6 commits into from
Oct 15, 2023

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Oct 15, 2023 •
edited
Loading

内容

ダウンローダーに以下の2つのオプションを追加します。

      --only <TARGET>...
          ダウンロード対象を限定する [possible values: core, models, additional-libraries, dict]
      --exclude <TARGET>...
          ダウンロード対象を除外する [possible values: core, models, additional-libraries, dict]
  • downloadクレート内にconflicts_with(_all)に対する単体テスト

関連 Issue

Resolves #642.

その他

@qryxip qryxip marked this pull request as ready for review October 15, 2023 13:45
@qryxip qryxip requested a review from Hiroshiba October 15, 2023 13:45
Hiroshiba
Hiroshiba reviewed Oct 15, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！！

一点ダウンロードの仕様に関してどうしようかの相談コメントだけ！

crates/download/src/main.rs Show resolved Hide resolved
crates/download/src/main.rs Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

depcecatedあたりに関しては、今後ダウンローダーがどう成長していくかわかんないので、とりあえず今はどっちでもいいかなと思いました！

@Hiroshiba Hiroshiba merged commit fc757a5 into VOICEVOX:main Oct 15, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ダウンローダーにcore.zip以外だけをダウンロードする機能を持たせる
2 participants
@qryxip @Hiroshiba