Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voice_synthesizer.rs → synthesizer.rs #657

Merged
merged 1 commit into from
Oct 25, 2023
Merged

voice_synthesizer.rs → synthesizer.rs #657

merged 1 commit into from
Oct 25, 2023

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Oct 25, 2023

内容

現在Synthesizerの実装は、SynthesizerがVoiceSynthesizerだったときの名残としてvoice_synthesizer.rsというファイルに置かれています。

このPRでは、現在の実態に即した名前であるsynthesizer.rsにリネームします。気付いたときにやらないと忘れる類のものかと思いました。

関連 Issue

その他

@qryxip qryxip requested a review from Hiroshiba October 25, 2023 16:27
Hiroshiba
Hiroshiba approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@Hiroshiba Hiroshiba merged commit dc8c3db into VOICEVOX:main Oct 25, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba