Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for full-context label and text analyzer #750

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

phenylshima
Copy link
Contributor

@phenylshima phenylshima commented Feb 22, 2024

内容

OpenJTalkとフルコンテキストラベルのパーサーに対するテストを実装します.

関連 Issue

ref: #742 (review)

その他

#742 との関係で,テストをtext_analyzer.rsではなくfull_context_label.rsに実装しています.

@phenylshima phenylshima force-pushed the full-context-label-test branch from 9405c4d to b6ab06a Compare February 22, 2024 23:03
@qryxip qryxip requested a review from Hiroshiba February 23, 2024 10:32
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

丁寧な進行ありがとうございます、助かります!!

Comment on lines +371 to +374
"xx^xx-sil+y=e/A:xx+xx+xx/B:xx-xx_xx/C:xx_xx+xx/D:xx+xx_xx/E:xx_xx!xx_xx-xx/F:xx_xx#xx_xx@xx_xx|xx_xx/G:1_1%0_xx_xx/H:xx_xx/I:xx-xx@xx+xx&xx-xx|xx+xx/J:1_1/K:1+1-1",
"xx^sil-y+e=sil/A:0+1+1/B:xx-xx_xx/C:09_xx+xx/D:xx+xx_xx/E:xx_xx!xx_xx-xx/F:1_1#0_xx@1_1|1_1/G:xx_xx%xx_xx_xx/H:xx_xx/I:1-1@1+1&1-1|1+1/J:xx_xx/K:1+1-1",
"sil^y-e+sil=xx/A:0+1+1/B:xx-xx_xx/C:09_xx+xx/D:xx+xx_xx/E:xx_xx!xx_xx-xx/F:1_1#0_xx@1_1|1_1/G:xx_xx%xx_xx_xx/H:xx_xx/I:1-1@1+1&1-1|1+1/J:xx_xx/K:1+1-1",
"y^e-sil+xx=xx/A:xx+xx+xx/B:xx-xx_xx/C:xx_xx+xx/D:xx+xx_xx/E:1_1!0_xx-xx/F:xx_xx#xx_xx@xx_xx|xx_xx/G:xx_xx%xx_xx_xx/H:1_1/I:xx-xx@xx+xx&xx-xx|xx+xx/J:xx_xx/K:1+1-1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここのラベルはどっちかというとOpenJTalkのテストになるので、そこは信頼しても良い(チェックを省いても良い)かもと思いました!
どちらでも良いかなと・・・!

@Hiroshiba Hiroshiba merged commit ce6297b into VOICEVOX:main Feb 23, 2024
36 checks passed
@phenylshima phenylshima deleted the full-context-label-test branch February 23, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants