Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python APIのasyncio版実装をmod内に移す #754

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Python APIのasyncio版実装をmod内に移す #754

merged 1 commit into from
Feb 26, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Feb 25, 2024

内容

Python APIのasyncio (with tokio)版実装に対し、 #710 と同じことをします。

関連 Issue

#710

その他

Hiroshiba
Hiroshiba approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

git diff -w --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space でみて、まあ変わって無さそうだということを確認しました！

sevenc-nanashi
sevenc-nanashi approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。

…ファイル分割とかしても良さそう？

@qryxip qryxip merged commit 94a3c0a into VOICEVOX:main Feb 26, 2024
31 checks passed
@qryxip qryxip deleted the mv-asyncio-impls-into-mods branch February 26, 2024 15:47
@qryxip
Copy link
Member Author

qryxip commented Feb 26, 2024

mod分離しているところがこことかSynthesizerとかと合わせて全5箇所あるので、各実装が高々数百行ならインラインmodの方が見通しが良いと思ったのですが、実際はどうなんですかね…?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevenc-nanashi sevenc-nanashi sevenc-nanashi approved these changes

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qryxip @Hiroshiba @sevenc-nanashi