Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cargo.lock #755

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix Cargo.lock #755

merged 1 commit into from
Feb 26, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Feb 26, 2024

内容

#742 のマージによりoutdatedになったCargo.lockを修復します。

関連 Issue

その他

こうなる可能性は知っていたので、レビューのときに手元で確認しとかないとなと思いつつ忘れてしまいました。

仕組みとして防止するにはmerge queueとかを使うとか?

@qryxip qryxip requested a review from Hiroshiba February 26, 2024 16:22
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

どこのリポジトリでも現状起こり得るやつですね・・・

merge queue、触ってみたいなと思いつつなんかややこしいんですよね 😇
レビュワーだったら2人approveでOK、メンテナだったら1人approveでOK、オーナーだったら0 approveでもOKみたいなルールがなんか作れなかった(あるいは作りづらかった)気がします・・・。

@Hiroshiba Hiroshiba merged commit 7bfb5bf into VOICEVOX:main Feb 26, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants