Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アイテムの可視性を必要最低限にする #759

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Mar 2, 2024

内容

Rustコードの全アイテムの可視性(visibility)を、可能な限り狭めます。
(いくつか見落としがあるかもしれません)

関連 Issue

Resolves #594.

その他

@qryxip qryxip requested a review from Hiroshiba March 2, 2024 13:51
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

これ自動でやってくれるツールとかありそうだなと思いました!
まあAPIは全部テストされてないと勝手に後悔やめちゃいそうですが。

@Hiroshiba Hiroshiba merged commit 0848630 into VOICEVOX:main Mar 3, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust API内の各アイテムの可視性を引き締める
2 participants