Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: renovate.jsonの"packagePatterns"を"depPatterns"に #787

Merged

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented May 2, 2024

内容

Renovateのページを開いたらこんな表示があったので対応します。ちなみにこのメッセージは、このリポジトリのissueにあるdashboardでも見れます。

image

"packagePatterns"と"depPatterns"の違いは以下のような感じらしいです。^Rust$は実際"packageName"ではなく"depName"を指していますし、上記のメッセージがその"warning"っぽい(ログを見ても同内容のwarningがある)ので、指示に従って置き換えるのが正解だと思います。

matchPackagePatterns will try matching packageName first and then fall back to matching depName. If the fallback is used, Renovate will log a warning, because the fallback will be removed in a future release. Use matchDepPatterns instead.

matchPackagePatterns - Configuration Options - Renovate Docs

関連 Issue

その他

@qryxip qryxip requested review from Hiroshiba and sevenc-nanashi May 2, 2024 15:34
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

別のリポジトリでもそろそろ導入してみたいですねぇ。

@Hiroshiba Hiroshiba merged commit 78c80e5 into VOICEVOX:main May 2, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants