fix: voicevox_user_dict_add_wordがスタックを破壊するのを修正
#800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sevenc-nanashi
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Rust 1.79に上げるとC APIのテストがSEGV(多分)することがわかりました。
https://github.com/VOICEVOX/voicevox_core/actions/runs/9505427859?pr=799
原因は
voicevox_user_dict_add_wordの実装です。起こっていることはおそらくこんな感じです。https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=3d7d63d7dd6216fbb5172391013be984
voicevox_user_dict_add_wordは現在output_wordに書き込む方法を誤っており、16バイトではなく16×16=256バイトをmemmoveしてスタックを破壊しています。書き込む方法を正しくすることで修正を行います。関連 Issue
その他