Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove!: macOS 12のサポートを切る #884

Merged
merged 1 commit into from
Dec 3, 2024
Merged

remove!: macOS 12のサポートを切る #884

merged 1 commit into from
Dec 3, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 3, 2024

内容

理由: actions/runner-images#10721

前回のは #801

関連 Issue

その他

@qryxip
Copy link
Member Author

qryxip commented Dec 3, 2024

@qryxip
Copy link
Member Author

qryxip commented Dec 3, 2024 •
edited
Loading

↑ test workflowが落ちてるのは別口ですね。 #885 を作りました。

ということでdraft外します。

[追記] download_testが通らないのも既知だったはず

@qryxip qryxip marked this pull request as ready for review December 3, 2024 16:36
@qryxip qryxip requested a review from Hiroshiba December 3, 2024 16:36
Hiroshiba
Hiroshiba approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@qryxip qryxip merged commit e72b909 into VOICEVOX:main Dec 3, 2024
34 checks passed
@qryxip qryxip deleted the remove-drop-macos-12 branch December 3, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba