fix: [release-0.15] os to runner_os #905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
$OS
となってますが、おそらく正解は$RUNNER_OS
です。release-0.15でビルドするとなぜかcbindgenがインストールされておらず、いろいろ調べたところここじゃないかとなりました。
よくよく確認すると、この前macos-12をmacos-13に上げるrelease-0.15へのPRのGithub Workflowでもそこで落ちてました。
2箇所変更していますが、
.github/actions/cargo-binstall-cbindgen/action.yml
側は現在のmainブランチには存在してません。.github/workflows/build_and_deploy.yml
側の.exe
を付けるか判定はこれでより正しくなるはず。でも
$OS
はWindowsでだけWindows_NT
と値が入ってるので、switch caseの仕様によっては正しく動作してるかも。試してみた結果がこちら
その他
なんで以前はちゃんとOS判定できてた?のか不明。
判定はできてなくて、cbindgenがなぜか入ってたのか、あるいはキャッシュがヒットしてたとか・・・?