Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Java APIのttsのテストが動いてなかったのを修正 #909

Merged
merged 1 commit into from
Dec 27, 2024
Merged

test: Java APIのttsのテストが動いてなかったのを修正 #909

merged 1 commit into from
Dec 27, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 27, 2024

内容

関連 Issue

その他

#908 の本文を書いてるときに発見しました。

@qryxip qryxip requested a review from Hiroshiba December 27, 2024 13:57
@qryxip qryxip mentioned this pull request Dec 27, 2024
Open
3 tasks
Hiroshiba
Hiroshiba approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

変更前のコードで実はTTSされてないというのは流石にそうは読めないですね･･･。
まあ実際使うときは返り値を使うので問題には気づけそうですが、だいぶ微妙そう。

@qryxip qryxip merged commit f755609 into VOICEVOX:main Dec 27, 2024
30 checks passed
@qryxip qryxip deleted the test-fix-java-api-tts-test branch December 27, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba