feat: voicevox_core (Rust API)以外のクレートをMIT Licenseと宣言
#913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
changed the title
voicevox_core (Rust API)以外のクレートをMITと宣言voicevox_core (Rust API)以外のクレートをMIT Licenseと宣言
qryxip
deleted the
feat-add-package-licenses-and-symlinks-to-license-file
branch
qryxip
added a commit
to qryxip/voicevox_core
that referenced
this pull request
Jan 5, 2025
qryxip
added a commit
that referenced
this pull request
Jan 15, 2025
1. manifest.jsonの"…_filename"部分を変更し、.binを認識できるようにする。 .binの場合、 VOICEVOX/ort#8 で追加される `SessionBuilder::commit_from_vv_bin`を用いる。 ```json "predict_duration": { "type": "onnx", "filename": "predict_duration.onnx" }, ``` ```json "predict_duration": { "type": "vv_bin", "filename": "pd.bin" }, ``` 2. `Onnxruntime::LIB_NAME`を`"onnxruntime"`から`"voicevox_onnxruntime"` にする。compatible_engineの場合だけ、`"voicevox_onnxruntime"`で失敗す ると`"onnxruntime"`にフォールバックするようにする（モック目的で使える ように）。 3. VOICEVOX/ort#8 でログのフィルタリングをやめる代わりに、C APIのログ フィルタの`ort=info`を`ort=warn`にする。 4. build_and_deploy_downloaderの`is_production`周りを吹き飛ばす。 5. #913 の続きとして、Rust APIの`package.license`を設定。 残る課題は以下の通り。 > README周り（たぶんcore.zip内のreadmeは削除で良さそう？） > #825 (comment) > > downloader周り（一旦壊れることになる･･･？いやならなさそうな気がする！） > #825 (comment) > > is_productionフラグを失くす？ > #825 (comment) #825 (review) Resolves: VOICEVOX/voicevox_project#24 Resolves: #388 Resolves: #722
qryxip
added a commit
that referenced
this pull request
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
voicevox_core(Rust API)以外のクレートのpackage.licenseを設定する。今後crates.ioに上げる可能性のあるvoicevox_core_macrosについては VOICEVOX/open_jtalk-rs#32 のようにLICENSEファイルへのシンボリックリンクを置く。voicevox_core(Rust API)についてだけは #825 の中で行う。関連 Issue
Refs: #332
その他