Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: ライブラリ関連の Model を移動 #1328

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 25, 2024

内容

ライブラリ関連の Model を library/model.py へ移動するリファクタリングを提案します。

関連 Issue

ref #1278 (comment)

@tarepan tarepan requested a review from a team as a code owner May 25, 2024 14:47
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 25, 2024 14:47
@tarepan tarepan marked this pull request as draft May 28, 2024 09:55
@tarepan tarepan marked this pull request as ready for review May 28, 2024 10:40
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

voicevox_engine/library/model.py Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit 4e0afc3 into VOICEVOX:master Jun 2, 2024
4 checks passed
@tarepan tarepan deleted the refactor/lib_model_merge branch June 2, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants