Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: 設定にモデルモジュールを追加 #1345

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 28, 2024

内容

エンジン設定に関するモデルモジュールを追加するリファクタリングを提案します。

関連 Issue

ref #1278 (comment)

@tarepan tarepan requested a review from a team as a code owner May 28, 2024 14:20
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 28, 2024 14:20
@tarepan tarepan changed the title refactor: 設定にモデルモジュールを追加 整理: 設定にモデルモジュールを追加 May 28, 2024
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit c61477e into VOICEVOX:master Jun 2, 2024
4 checks passed
@tarepan tarepan deleted the refactor/model_setting branch June 2, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants